Regional Partner is now editable in the workshop form #20811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mehalshah
commented
Feb 22, 2018
mehalshah
commented
|
May be fixing a bunch of tests for this |
aoby
approved these changes
Feb 22, 2018
| loadRegionalPartners() { | ||
| this.loadRegionalPartnersRequest = $.ajax({ | ||
| method: "GET", | ||
| url: '/api/v1/regional-partners/for_user', |
There was a problem hiding this comment.
As discussed offline, please change this route in a followup PR to be /api/v1/regional-partners, switch the action from for_user to index, and rename the existing index action something like for_district_and_course since it's less standard / more specific.
| value={this.state.regional_partner_id || ''} | ||
| disabled={this.props.readOnly} | ||
| > | ||
| <option value=""/> |
There was a problem hiding this comment.
Should this null option maybe say "None", or should the control have placeholder text?
There was a problem hiding this comment.
I'll make the null option say "none"
…ethods Rename regional partner methods
aoby
approved these changes
Feb 22, 2018
| @@ -1,6 +1,6 @@ | |||
| class Api::V1::RegionalPartnersController < ApplicationController | |||
| # GET /api/v1/regional-partner/<school_district_id>/<course> | |||
| def index | |||
| # GET /api/v1/regional_partner/<school_district_id>/<course> | |||
There was a problem hiding this comment.
nit: regional_partners (pluralize). Same below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.