Two last bug fixes for registration form #20842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
reviewed
Feb 22, 2018
| @@ -149,7 +150,7 @@ export default class TravelPlans extends Teachercon1819FormComponent { | |||
| { | |||
| this.props.data.needHotel === 'Yes' && | |||
| this.props.data.needAda === 'Yes' && | |||
| this.largeInputFor("explainAda", {required: false}) | |||
| this.largeInputFor("explainAda") | |||
There was a problem hiding this comment.
is this also getting appropriately required on the server?
There was a problem hiding this comment.
Yes, it already was. The required just meant that the asterisk was/wasn't showing up
Hamms
approved these changes
Feb 22, 2018
balderdash
deleted the
hide_teachercon_registration_pages_if_facilitator_declines_seat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExplainAda wasn't actually getting required
Needed to hide sections 2 and 3 for both teachers and facilitators who are not attending