Facilitators can create workshops with regional partners #20881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehalshah
force-pushed
the
facilitators_can_create_workshops_with_regional_partners
branch
from
b860130
to
ecbf985
Compare
New permissions for csf facilitators Hide delete butotn for facilitators
mehalshah
force-pushed
the
facilitators_can_create_workshops_with_regional_partners
branch
from
02158fa
to
659540c
Compare
aoby
approved these changes
Feb 26, 2018
There was a problem hiding this comment.
LGTM
Our client-side permissions are fairly scattered. I wonder if it would make sense to consolidate into the permissions class, adding properties like canCreateWorkshop, canDeleteWorkshop etc?
|
|
||
| return ( | ||
| <div> | ||
| <h1>Your Workshops</h1> | ||
| <ButtonToolbar> | ||
| {(this.permission.isWorkshopAdmin || this.permission.isOrganizer) && | ||
| {(this.permission.isWorkshopAdmin || this.permission.isOrganizer || this.permission.isCsfFacilitator) && |
There was a problem hiding this comment.
How about calling this out above as const canCreate, like we do for canDelete, for consistency and readability?
balderdash
deleted the
facilitators_can_create_workshops_with_regional_partners
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facilitators now have permissions to create workshops with regional partners