Regional partner contact logic

[tessawiedmann]

Updated logic for matching regional partners to use find_by_region which uses state and zip codes. Also updated tests for that logic

[sureshc]

I'm not familiar with the regionalPartnerContact feature, but I'm wondering if there should be new tests in regional_partner_contact_test.rb to verify that the new matching logic is working?

[tanyaparker]

I'll let Clare review the code, but the principle looks good to me.

Can we add a test for each scenario of matching? Say someone is from a school

1. in a state with no regional partners (so it remains unmatched)
2. in a state w/ only 1 Regional Partner like Nebraska (so it matches using state)
3. in a state w/ several partners like Texas (so it matches uses zip)

[clareconstantine]

@sureshc @tanyaparker since the actual matching logic hasn't changed - we are just calling the existing method on RegionalPartner which is tested here, it felt a little redundant. But we can definitely add them for extra peace of mind!

[sureshc]

Oops, yes. There are plenty of test on the RegionalPartner model itself. I don't think any redundant tests are needed here except to ensure that RegionalPartnerContact works as expected now that it's using the matching method provided by RegionalPartner

[tanyaparker]

Oh! Didn't notice I was redundant with Suresh's feedback. And agree, we don't need additional tests if it's already tested. :D

[sureshc]

@tessawiedmann The new test looks good!