lock ruby_dep version to ~> 1.3.1 for ruby 2.2.3 support #20894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
approved these changes
Feb 26, 2018
Hamms
added a commit
that referenced
this pull request
Mar 14, 2023
In #20894, we added an explicit dependency on `ruby_dep` so we could specify the version that gets installed by the `listen` gem (a dependency of `rerun`), which at the time depended on it. The `listen` gem no longer has this dependency, so we no longer need it at all! Also, it's preventing a a potential upgrade to Ruby 3.0: ``` Bundler found conflicting requirements for the Ruby version: In Gemfile: ruby_dep (~> 1.3.1) was resolved to 1.3.1, which depends on Ruby (>= 2.0.0, ~> 2.0) Current Ruby version: Ruby (= 3.0.5) ```
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression in #20878 for Ruby 2.2.3. This PR adds a workaround for
ruby_dep, which is an explicit-ruby-version-whitelisting 'feature' used by thelistengem (which is a dependency ofrerun, which was updated in the referenced PR). What a terrible idea.