Remove fastclick from code.org #20918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we still using it on any of our sites? If not, we should probably remove the theme and other associated files too, just to keep things cleaned up. I'm still not sure why this was necessary if the |
|
The issue is on the react virtualized select components which don't appear to use selectize internally and there isn't a way to set needsclick on those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #19035, removing fast click from code.org.
We also ought to remove selectize-fast-click.js. I haven't had a chance to find all the places where it is used and to test the effects of removing it. Meanwhile, I would like to get this change in so that we can make sure the school dropdown works fine on /yourschool for iOS devices.