Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify .feature files as snake_case #20938

Merged
merged 1 commit into from Feb 28, 2018
Merged

Unify .feature files as snake_case #20938

merged 1 commit into from Feb 28, 2018

Conversation

joshlory
Copy link
Contributor

Context: https://codedotorg.slack.com/archives/C0T0PNTM3/p1519843247000508

Dir.glob('test/ui/features/**/*.feature').each do |entry|
  File.rename(entry, entry.underscore)
end

@joshlory
Unify .feature files as snake_case
beb4517 
`Dir.glob('test/ui/features/**/*.feature').each{ |entry| File.rename(entry, entry.underscore) }`
Erin007
Erin007 approved these changes Feb 28, 2018
View reviewed changes
Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👏

davidsbailey
davidsbailey approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ruby-fu on the rename!

@joshlory joshlory merged commit 8b01b54 into staging Feb 28, 2018
@joshlory joshlory deleted the cucumber-snake-case branch February 28, 2018 22:00
@islemaster islemaster mentioned this pull request Mar 5, 2018
Merged
@Erin007 Erin007 mentioned this pull request Mar 6, 2018
Merged
@Erin007 Erin007 mentioned this pull request Apr 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

@Erin007 Erin007 Erin007 approved these changes

Assignees

@davidsbailey davidsbailey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshlory @davidsbailey @Erin007