Launch Manage Students Table! #20981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleybrock
force-pushed
the
remove-experiment
branch
from
0ad9025
to
a8530e4
Compare
Erin007
reviewed
Mar 6, 2018
| %th{colspan: "4", style: "padding-top:5px;padding-bottom:5px"} | ||
| %th.manage-th{style: "padding-top:5px;padding-bottom:5px; height:45px"} | ||
| %button.btn.btn-primary{"ng-click" => "save(section.students)", "ng-show" => "editingAny(section.students)", style: "float:left", "ng-disabled" => "allForm.$invalid"}= I18n.t('dashboard_action_save_all') | ||
|
|
Erin007
approved these changes
Mar 6, 2018
islemaster
approved these changes
Mar 6, 2018
| .managebuttons{style: "float:right; margin-bottom: 9px;", "ng-if" => "tab == 'manage' && teacher_managed_section(section)"} | ||
| %span{"ng-if" => "section.login_type !== 'email'"} | ||
| %button.btn.btn-white{"ng-click" => "new_student()", "ng-disabled" => "bulk_import.editing"}= I18n.t('dashboard_students_add_student') | ||
| %button.btn.btn-white{"ng-click" => "bulk_import.editing = true", "ng-disabled" => "bulk_import.editing"}= I18n.t('dashboard_students_add_students') |
There was a problem hiding this comment.
Can we remove the i18n strings dashboard_students_add_student and dashboard_students_add_students?
There was a problem hiding this comment.
These are all gsheet controlled, so I'll remove once this PR gets merged.
There was a problem hiding this comment.
Removed all unused strings from gsheet 👍
| %col{width: "250"}/ | ||
| %tr | ||
| %th.manage-th | ||
| %a{href: "", "ng-click" => "order = 'name'"}= I18n.t('dashboard_students_name') |
There was a problem hiding this comment.
Likewise any strings in here? (Not sure which are still used elsewhere, there are a lot).
caleybrock
changed the title
|
Got approval from Poorva. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll merge this once I get the go ahead from Poorva.