-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new census map UI test #20995
Add new census map UI test #20995
Conversation
Trying to figure out why the new test works fine for me but then is failing in circle. |
I was finally able to get this new test to pass and it is ready to be reviewed. In addition to the test there are two other changes that were needed:
|
Then /^I scroll the "([^"]*)" element into view$/ do |selector| | ||
@browser.execute_script("$('#{selector}')[0].scrollIntoView(true)") | ||
end | ||
|
||
Then /^I scroll the save button into view$/ do | ||
@browser.execute_script('$(".uitest-saveButton")[0].scrollIntoView(true)') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we refactor so that this function calls the new one above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the more specific step isn't actually in use anywhere so I'm just going to remove it.
Then I click selector "button.close" if it exists | ||
|
||
# Chose school from the map school dropdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Choose :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose to fix this typo.
Addressing PR feedback from #20978. No rush on reviewing this.
A bunch of small changes plus I added a test of the new functionality to confirm that after selecting a school from the map dropdown and clicking the info window link that the school id in the form is set correctly.