Video thumbnail by key #21018
Merged
Video thumbnail by key #21018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleybrock
approved these changes
Mar 5, 2018
There was a problem hiding this comment.
🙏 Logically this makes so much more sense, but I have one concern.
Although having a DTT fail with mismatching thumbnails is annoying, it also ensures we scoop thumbnails before deploying. My concern here is we might end up in a case where we are using a new video from LB, but the thumbnail gets left behind on staging. It'd only break the new video, but it wouldn't be great.
If it's gonna be a while before we add thumbnail generation to LB, I'm concerned about this. If the thumbnail generation is on its way, I think we can live with that risk for a bit.
|
Moving the cronjob code to happen on individual video save is next on my list 😄 |
|
Perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we name videos by
id, theiridcan change as we add new videos in the middle of videos.csv. If we happen to scoop content before thumbnails update, every thumbnail after the added video is off by one.Instead name videos by
keywhich doesn't change.