Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind obstacle failure timout handler #21019

Merged
merged 1 commit into from Mar 5, 2018
Merged

Bind obstacle failure timout handler #21019

merged 1 commit into from Mar 5, 2018

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Mar 5, 2018

So that this.playAudioOnFailure is not undefined

@Hamms
Bind obstacle failure timout handler
db13064 
So that `this.playAudioOnFailure` is not undefined
@Hamms Hamms requested a review from islemaster March 5, 2018 22:52
islemaster
islemaster approved these changes Mar 5, 2018
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@Hamms
Copy link
Contributor Author

Hamms commented Mar 5, 2018

Thanks for bringing it to my attention!

@Hamms Hamms merged commit 979a805 into staging Mar 5, 2018
@Hamms Hamms deleted the fix-playAudioOnFailure branch March 5, 2018 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @islemaster