Gl Animation Loss Blank Animation Fix #21040
Conversation
| return addLibraryAnimation( | ||
| { | ||
| name: 'animation', | ||
| sourceUrl: '/api/v1/animation-library/mUlvnlbeZ5GHYr_Lb4NIuMwPs7kGxHWz/category_backgrounds/blank.png', |
There was a problem hiding this comment.
😂 There's something wonderfully elegant about this. It also might not be 100% intuitive. Can we add a comment in addBlankAnimation() explaining this strategy of adding a secret, empty library animation?
There was a problem hiding this comment.
Example library animation props.
{
"name": "bear",
"frameCount": 1,
"frameSize": {
"x": 254,
"y": 333
},
"looping": true,
"frameDelay": 2,
"jsonLastModified": "2017-04-18 05:56:09 UTC",
"pngLastModified": "2017-04-18 05:56:10 UTC",
"version": "vCJXAsYgUPWoNTt5h.OKY_tF3cEEY_Sf",
"sourceUrl": "/api/v1/animation-library/vCJXAsYgUPWoNTt5h.OKY_tF3cEEY_Sf/category_animals/bear.png",
"sourceSize": {
"x": 254,
"y": 333
}
}
| frameDelay: 4, | ||
| version: 'mUlvnlbeZ5GHYr_Lb4NIuMwPs7kGxHWz', | ||
| loadedFromSource: true, | ||
| saved: false |
There was a problem hiding this comment.
I suspect not all of these props are needed. Let's double check the format for library animation props and conform to that.
There was a problem hiding this comment.
My bad, didn't realize you'd already updated the Piskel dependency in #21093.
| And I open the animation picker | ||
| And I select a blank animation | ||
| STEPS | ||
| end |
There was a problem hiding this comment.
Are you also adding a UI test that uses these new steps?
There was a problem hiding this comment.
Glad you pointed this out! I already wrote one but forgot to add it to the PR. Added in latest commit.
Removes the special case for drawing your own animation.
Prev - don't save anything to V3, but save a reference in the manifest. When loaded, look for this special case and build a new Piskel.
New - Blank animation in the animation library. Draw-your-own calls this animation and then treats edits to it like a normal animation library change.
Blank Animation in animation library is 'deleted' and retrieved via version id so it won't appear in student-facing animation library. The animation was found by manually saving and downloading blank 'drawn' animation. Can be found: cdo-animation-library/category_backgrounds/blank.png
cc: @poorvasingal