Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix funding / funding type workshop requirements #21120

Merged
merged 1 commit into from Mar 8, 2018
Merged

Fix funding / funding type workshop requirements #21120

merged 1 commit into from Mar 8, 2018

Conversation

aoby
Copy link
Contributor

@aoby aoby commented Mar 8, 2018

Now:

image

@aoby aoby requested a review from mehalshah March 8, 2018 19:47
aoby
aoby commented Mar 8, 2018
View reviewed changes
dashboard/app/models/pd/workshop.rb

validates :funding_type,
presence: {if: :funded_csf?},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized this was redundant with the inclusion on the next line.

@aoby aoby merged commit 2efe2cd into staging Mar 8, 2018
@aoby aoby deleted the fix-workshop-funding-requirement branch March 8, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehalshah mehalshah Awaiting requested review from mehalshah

Assignees
No one assigned
Labels
bug-fix professional-learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aoby