Size block #21322
Size block #21322
Conversation
apps/src/turtle/turtle.js
Outdated
| @@ -1585,7 +1585,7 @@ Artist.prototype.step = function (command, values, options) { | |||
| this.visualization.ctxScratch.save(); | |||
| this.visualization.ctxScratch.translate(this.visualization.x, this.visualization.y); | |||
| this.visualization.ctxScratch.rotate(this.visualization.degreesToRadians_(this.visualization.heading)); | |||
| this.visualization.ctxScratch.drawImage(img, 0, 0, width, height, -width / 2, -height, width, height); | |||
| this.visualization.ctxScratch.drawImage(img, -width / 2, -height, width, height); | |||
There was a problem hiding this comment.
I repro the IndexSizeError: DOM Exception 1 with the following code:
phantomjs> img = new Image(100, 100);
phantomjs> ctx = document.createElement('canvas').getContext('2d');
phantomjs> ctx.drawImage(img, 0, 0, 100, 100);
IndexSizeError: DOM Exception 1
phantomjs://repl-input:1 in global code
Can we continue to pass all 9 arguments here to fix the failing test?
apps/src/turtle/blocks.js
Outdated
| @@ -1129,6 +1129,39 @@ exports.install = function (blockly, blockInstallOptions) { | |||
| '", null, \'block_id_' + this.id + '\');\n'; | |||
| }; | |||
|
|
|||
| blockly.Blocks.turtle_sticker_with_size = blockly.Blocks.turtle_stamp = { | |||
There was a problem hiding this comment.
Why also export as turtle_stamp?
There was a problem hiding this comment.
Redundant! Thanks for spotting.
|
|
||
| dropdown = new blockly.FieldImageDropdown(values, 40, 40); | ||
|
|
||
| input.appendTitle(dropdown, 'VALUE'); |
There was a problem hiding this comment.
I wonder if we can share the code from line 1134-1149 and 1152-1155 with blockly.Blocks.sticker above?
There was a problem hiding this comment.
Deleted "turtle_stamp" from lines 1132 & 1160.
apps/src/turtle/blocks.js
Outdated
|
|
||
| generator.turtle_sticker_with_size = generator.turtle_stamp = function () { | ||
| var size = generator.valueToCode(this, 'SIZE', Blockly.JavaScript.ORDER_NONE); | ||
| return 'Turtle.drawSticker("' + this.getTitleValue('VALUE') + '", ' + size + ', \'block_id_' + this.id + '\');\n'; |
There was a problem hiding this comment.
Nit: this is a perfect use case for string interpolation 😄.
|
Updated feedback. Please take a look. |
|
"Set sticker size" implies to me that it's changing the size of the sticker drawn by the "draw sticker" block. I'd suggest we instead label this block something like |
apps/src/turtle/blocks.js
Outdated
| this.setPreviousStatement(true); | ||
| this.setNextStatement(true); | ||
| this.setTooltip(msg.drawSticker()); | ||
| this.setTooltip(msg.setStickerSize()); |
There was a problem hiding this comment.
Does setting two tooltips make sense, or will the second override the first?
| artist.step('sticker', ['Alien', size, blockId], options); | ||
|
|
||
| expect(setStickerSize).to.be.have.been.calledWith(img, 0, 0, 100, 40, -15, -12, 30, 12); | ||
|
|
|
Updated PR, please review. |
This PR covers the addition of a new size block with a size input and sticker dropdown.
Previously, users did not have the option to input a custom size as shown in "initial option" below. The addition of the size block to the toolbox, gives users the option to input a custom size to enhance user experience.
Initial option
This is the implementation of the new size block that allows a user to input any numerical value for size. The sticker drawn is resized per the size input.
Artist toolbox that includes two sticker options
