I18n sync HOC Down & Out 03/26 #21473
Conversation
| @@ -10,7 +10,7 @@ nav: how_to_nav | |||
| ## 1. Prepárate para tu evento | |||
|
|
|||
| - Elige lugar, fecha y hora. | |||
| - Envía [una carta](https://docs.google.com/a/code.org/document/d/1eP41sKW7y0qq_JvkRIgZK8dWYICaGRZ4CCDETXa78wY/edit) invitando al alcalde, diputado, presidente autonómico o empresario influyente para que de una charla. Consulta nuestras [herramientas prácticas](%=resolve_url('/files/elected-official.pdf')%) cuando alojes a un funcionario durante una hora de código para obtener más información. | |||
| - Send [a letter](https://hourofcode.com/promote/resources#sample-emails) to invite your local mayor, congressman, governor, or influential business person to speak. Check out our [how-to toolkit](%=localized_file('/files/elected-official.pdf')%) when hosting an elected official during an Hour of Code for more info. | |||
There was a problem hiding this comment.
Did we lose the translation because we changed from resolve_url to localized_file?
| @@ -5,7 +5,7 @@ nav: promote_nav | |||
| --- | |||
| <%= view :signup_button %> | |||
|
|
|||
| <% facebook = {:u=>"http://#{request.host}/es"} | |||
| <% facebook = {: u => "http://#{request.host}/ nos"} | |||
There was a problem hiding this comment.
Looks like this was translated when it shouldn't have been.
| @@ -10,7 +10,7 @@ nav: promote_nav | |||
|
|
|||
|
|
|||
|
|
|||
| Ir a [< % = resolve_url('code.org/promote') %>](%= resolve_url('https://code.org/promote') %) para encontrar información específica de estado sobre Ciencias de la computación. | |||
| Go to [code.org/promote](%= codeorg_url('/promote') %) to find state specific information about computer science. | |||
There was a problem hiding this comment.
Yeah, it looks like where we changed the function from resolve_url to codeorg_url it reset the translation. Any way we can keep these?
There was a problem hiding this comment.
Hmm, maybe. If resolve_url still works, I could undo the parts of #21466 that included those changes, and sync them up again but with the update_without_changes option.
There was a problem hiding this comment.
does resolve_url still work? And if so, do you see any problems with that solution?
There was a problem hiding this comment.
Brendan made these updates when he removed the redirects to xx.code.org partner sites. resolve_url still works, but it's now for hourofcode.com urls only. Then we use codeorg_url to preserve the environment.
So we definitely want all the strings to have codeorg_url instead of resolve_url so it looks like we would need to do special work to keep the translation. I don't think this is high priority enough to sidetrack other i18n work, so we may have to settle for asking for a re-translation.
| @@ -160,6 +160,6 @@ nav: promote_nav | |||
|
|
|||
| 诚挚地， | |||
|
|
|||
| [您的名字], [职位] | |||
| [Your Name], [Title] | |||
There was a problem hiding this comment.
I wonder why we'd lose the translation here?
There was a problem hiding this comment.
Looks like we didn't lose it, it just got changed to this in crowdin: https://crowdin.com/translate/hour-of-code/612/en-zhcn#109293
There was a problem hiding this comment.
Fun! Well not an error with sync, so this issue shouldn't block merging.
Hamms
force-pushed
the
i18n-sync-hoc-out-03-26
branch
from
b7febd5
to
50a9d9f
Compare
No description provided.