standardize capitalization of 'Please Explain' in pd applications #21488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a script to standardize the capitalizations for already-submitted applications |
clareconstantine
force-pushed
the
standardize_capitalization
branch
from
588467f
to
3d91df1
Compare
mehalshah
approved these changes
Apr 2, 2018
| # then update, save, and score its corresponding teacher application | ||
| Pd::Application::PrincipalApproval1819Application.find_each do |principal_application| | ||
| if principal_application.form_data.include?("(please explain)") | ||
| principal_application.form_data = principal_application.form_data.gsub("(please explain)", "(Please Explain)") |
There was a problem hiding this comment.
This is fine. There's also an update_form_data_hash but since this is just a gsub its fine
| principal_application.form_data = principal_application.form_data.gsub("(please explain)", "(Please Explain)") | ||
| principal_application.save | ||
| if principal_application.errors | ||
| puts "principal app: #{principal_application.id} errors: #{principal_application.errors.full_messages}" |
There was a problem hiding this comment.
If you have an error here, consider not doing anything else with this application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.