Update loofah gem #21499
Merged
Update loofah gem #21499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewjordan
commented
Mar 27, 2018
| @@ -283,6 +283,8 @@ gem 'StreetAddress', require: "street_address" | |||
|
|
|||
| gem 'recaptcha', require: 'recaptcha/rails' | |||
|
|
|||
| gem 'loofah', ' ~> 2.2.1' | |||
There was a problem hiding this comment.
Is this the right way to force this, or should I just do it in the lock file?
There was a problem hiding this comment.
Since we version-control the lock file either is fine for bumping a version. This way makes it more explicit we're requiring a version-range for a specific reason, so slightly better.
wjordan
approved these changes
Mar 27, 2018
| @@ -283,6 +283,8 @@ gem 'StreetAddress', require: "street_address" | |||
|
|
|||
| gem 'recaptcha', require: 'recaptcha/rails' | |||
|
|
|||
| gem 'loofah', ' ~> 2.2.1' | |||
There was a problem hiding this comment.
Since we version-control the lock file either is fine for bumping a version. This way makes it more explicit we're requiring a version-range for a specific reason, so slightly better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in the fix for CVE-2018-8048 - Loofah XSS Vulnerability