Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update annotate gem to 2.7.2 to remove Ruby 2.4 Fixnum and Bignum deprecation warnings #21500

Merged
merged 1 commit into from Mar 28, 2018
Merged

Update annotate gem to 2.7.2 to remove Ruby 2.4 Fixnum and Bignum deprecation warnings #21500

merged 1 commit into from Mar 28, 2018

Conversation

aoby
Copy link
Contributor

@aoby aoby commented Mar 27, 2018 •
edited

Running bundle exec rake db:migrate was logging these warnings to console (copied from Eric):

/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Fixnum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Fixnum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Bignum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Fixnum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Bignum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Fixnum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Bignum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Fixnum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Bignum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Fixnum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Bignum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Fixnum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Bignum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Fixnum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Bignum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Fixnum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Bignum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Fixnum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Bignum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Fixnum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Bignum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Fixnum is deprecated
/Users/ericjordan/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/annotate-2.7.1/lib/annotate/annotate_models.rb:169: warning: constant ::Fixnum is deprecated
Model files unchanged.

Context: Fixnum and Bignum were consolidated into Integer in Ruby 2.4.

The latest annotate release contains a fix to remove the warnings.

@aoby aoby requested review from wjordan and ewjordan March 27, 2018 21:40
wjordan
wjordan approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@wjordan wjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aoby aoby merged commit 4c1d66b into staging Mar 28, 2018
@aoby aoby deleted the update-annotate-gem branch March 28, 2018 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjordan wjordan wjordan approved these changes

@ewjordan ewjordan ewjordan approved these changes

Assignees
No one assigned
Labels
code-hygiene
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aoby @wjordan @ewjordan