Resources tab bug fixes #21556
Merged
Resources tab bug fixes #21556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleybrock
reviewed
Mar 29, 2018
There was a problem hiding this comment.
Chatted offline. The negative margin is a bit odd, and it'd be preferable to use the same component that gets pulled up via documentation blocks, that way you don't have to worry about styling. Don't want to de-rail you too much, but if it's a simple-ish change, I think it's preferable.
| @@ -4,6 +4,8 @@ import color from '@cdo/apps/util/color'; | |||
| import BaseDialog from '../BaseDialog'; | |||
| import FontAwesome from '@cdo/apps/templates/FontAwesome'; | |||
|
|
|||
| const dialogRatio = 0.8; | |||
There was a problem hiding this comment.
nit: const values at the top should be in the format DIALOG_RATIO
https://google.github.io/styleguide/javascriptguide.xml#Constants
|
@caleybrock PTAL - I updated it to use the Legacy Dialog per our offline discussion. |
caleybrock
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bug requests for the dialog that pops up when you click on a resource in the resources tab.