Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set/remove tint blocks for gamelab jr #21557

Merged
merged 5 commits into from
Mar 30, 2018
Merged

Add set/remove tint blocks for gamelab jr #21557

merged 5 commits into from
Mar 30, 2018

Conversation

balderdash
Copy link
Contributor

image

FYI @caleybrock, @mrjoshida: With this PR, Sprite.tint and Group.setTintEach will work in gamelab sr, but I'm not adding it to the palette or the autocomplete config because there's no documentation yet.

Copy link
Contributor

@joshlory joshlory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Does tint amount depend on color brightness? If I want to fade a sprite's tint from 0% to 50% red over 20 frames, can I do that with the current block?

code-dot-org/p5.play#28

@mrjoshida
Copy link
Contributor

We've wanted this for Senior for a while, let's not block on documentation getting it into the pallete. I'll work on getting a documentation page up.

@balderdash balderdash requested a review from epeach March 29, 2018 22:33
@balderdash
Copy link
Contributor Author

Added them to the palette, @epeach could you take a look at 5051a49?

@epeach
Copy link

epeach commented Mar 29, 2018

LGTM! I'm excited to see this in GL!

@balderdash
Copy link
Contributor Author

@joshlory there's no "tint amount" option, so you can only vary the color intensity by using more/less saturated tint colors. In a pinch, you can do this:

image

@balderdash balderdash merged commit 92eb3a8 into staging Mar 30, 2018
@balderdash balderdash deleted the sprite-tint branch April 4, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants