Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State facts: add info from principals & remove federal question #21578

Merged
merged 3 commits into from Apr 2, 2018
Merged

State facts: add info from principals & remove federal question #21578

merged 3 commits into from Apr 2, 2018

Conversation

breville
Copy link
Member

@breville breville commented Mar 30, 2018 •
edited

no
screenshot 2018-03-30 13 25 58

yes
screenshot 2018-03-30 13 29 16

other
screenshot 2018-03-30 13 31 14

Confirmed that bullet doesn't show for 0% case.

Also removed a federal question.

tanyaparker
tanyaparker approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@tanyaparker tanyaparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was wrong in the spec, sorry. I think it should be "According to a representative survey" (add the "to").

@breville breville merged commit d64739b into staging Apr 2, 2018
@breville breville deleted the state-promote-principals branch April 2, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanyaparker tanyaparker tanyaparker approved these changes

@Erin007 Erin007 Erin007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@breville @tanyaparker @Erin007