Progress: Variable column widths #21600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleybrock
approved these changes
Apr 2, 2018
|
My only lingering concern is around the ability to sort. It's not part of the initial work but something Poorva definitely wants in revisions. Looks like it's possible: bvaughn/react-virtualized#650, but I haven't tried to implement it yet. |
|
Good point. I think it's possible, and it'll probably be expensive to sort and re-render so we'll likely need to build some customization into it anyways. I also have a feeling we'll have to build a second version of these tables without any css, just for the purpose of printing. I know that's a V2, but it's something to think about, especially if it means maintaining two tables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is confirmation that Virtualized MultiGrid allows us to have variable column widths. I pass in a hardcoded list of widths to a
getColumnWidthsfunction; in the future the width of the column will be based on the number of levels in the lesson. I also hardcoded a list of filler data to be passed to theMultigridso it starts to show info more in line with what will really be shown in the table.In this PR, I also reworked the styles and helper functions to be more consistent with format of other components in our codebase.