Progress: populate table with real student names #21609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleybrock
approved these changes
Apr 2, 2018
|
|
||
| getColumnWidth({index}) { | ||
| return columnWidths[index]; | ||
| } | ||
|
|
||
| render() { | ||
| const {section} = this.props; | ||
| const rowCount = section.students.length + 2; |
There was a problem hiding this comment.
a comment here would be helpful to explain why you're adding two
| const columnWidths = [150, 50, 100, 300, 50]; | ||
|
|
||
| export default class VirtualizedDetailView extends Component { | ||
|
|
||
| static propTypes = { |
There was a problem hiding this comment.
not required for this PR, but once the structure of our data is totally settled, we should pull this prop shape out as a constant so we can import and use the same thing everywhere.
| {(rowIndex === 1 && columnIndex === 0) && ( | ||
| <span style={styles.cell}>Level Type</span> | ||
| )} | ||
| {(rowIndex >= 2 && columnIndex === 0) && ( |
There was a problem hiding this comment.
Having students[rowIndex-2] being calculated in multiple places feels like it'll be easy to make a mistake. Might be worth having a const studentIndex = rowIndex - 2; at the top so that can be used everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use real data about section students to populate the name column for the detail view of the progress table, following the same structure as
SectionScriptProgress.