CircleCI: Set special s3 buckets after unit tests #21616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't set up special v3 api s3 directories until after the unit tests, before the ui tests. We need these for reliable UI tests but they mess with VCR in our ruby tests that check exact server requests, including the expected buckets, etc.
islemaster
force-pushed
the
circle-s3-bucket-after-unit-tests
branch
from
8fdc5bb
to
de58035
Compare
davidsbailey
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in the Circle run for #21608 that the new Circle-specific subdirectory names that make our UI tests more reliable on Circle are actually breaking our shared "unit" tests that use VCR to mock exact requests to S3.
This wasn't caught when that configuration change went in because changes to .circleci/config.yml don't cause any of our unit test suites to run.
So here I'm making two changes: