Log start and failure of staging builds to metrics database #21642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild to metrics database.
epeach
approved these changes
Apr 3, 2018
davidsbailey
approved these changes
Apr 3, 2018
aws/ci_build
Outdated
| # @param [String] commit_hash | ||
| # @param [String] status | ||
| # @param [String] status - :start, :success, :failed |
There was a problem hiding this comment.
nit: the type is listed as String, but the values you listed are Symbols. Probably best to list the type as Symbol if you care which is used, or Symbol|String otherwise.
wjordan
approved these changes
Apr 3, 2018
aws/ci_build
Outdated
| # @param [String] commit_hash | ||
| # @param [String] status | ||
| # @param [String] status - :start, :success, :failed |
There was a problem hiding this comment.
(nit) looks like the expected type is [Symbol] not [String] here (though it doesn't seem to make a difference in the current implementation since it's only interpolated in a string)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on logic in #21415 to also write start of staging builds and when staging build fails.