Access report: temporarily hide the banner on the teacher homepage #21644
Conversation
| def show_census_teacher_banner? | ||
| # Temporarily hide the banner |
There was a problem hiding this comment.
How temporary? And will we want to be able to override hide/show like this in the future? If so, we'll probably want a more robust solution than disabling rubcop and returning false. If temporary means a couple days and we don't anticipate needing to do this again, then I guess it seems fine.
There was a problem hiding this comment.
Great question. It will be hidden for roughly 2.5 weeks, and turning it back on will be done in sync with flipping another banner off which is why we decided to do it via manual PRs for now. I'm not sure whether we have a longer-term schedule since this particular call to action is relative new territory for us. Totally agreed that if we see this occurring too often we should build a better flipping solution.
There was a problem hiding this comment.
The most obvious immediate alternative would be to simply replace the function with false but I prefer keeping code intact that we know we're about to revive.
|
cc @mirlew |
|
lgtm |
Hide Professional learning special announcement from /yourschool and teacher /home (though leaving code intact, since I still have aspirations of making this more flag-driven for future years). Show the access report again on the teacher homepage, essentially reversing #21644.
We discussed programmatically reactivating on a set date, but the date of the reappearance and its coordination with removing other banners is still in flux.