Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily skip Pegasus page rendering test #21703

Merged
merged 2 commits into from
Apr 5, 2018

Conversation

sureshc
Copy link
Contributor

@sureshc sureshc commented Apr 5, 2018

The test_render_pegasus_documents test is failing on some new Advocacy pages. The problems with those pages are safe to deploy to production. Temporarily no-op this method to skip the test.

Is there an argument I can pass here to skip a test?

def self.run_pegasus_tests
Dir.chdir(pegasus_dir) do
ChatClient.wrap('pegasus tests') do
RakeUtils.rake_stream_output 'test'
end
end
end

@sureshc sureshc requested review from wjordan and breville April 5, 2018 21:25
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No linter warnings about unreachable code?

This is the fastest way I know to get things working again too.

@sureshc sureshc merged commit af089e1 into staging Apr 5, 2018
@sureshc sureshc deleted the temporarily-skip-pegasus-rendering-test branch April 5, 2018 21:41
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link
Contributor

@wjordan wjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

breville added a commit that referenced this pull request Apr 10, 2018
Reenabling the test disabled in #21703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants