New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advocacy site: updates to map & info box. #21806
Conversation
Also some content changes to the rest of the site.
They accidentally got staged when reapplying a stash, but shouldn't have been committed.
Some thoughts
|
Can you include screenshot of the box before a state is selected? |
@@ -137,9 +137,6 @@ | |||
font-weight: bold; | |||
text-align:center; | |||
} | |||
.fact { | |||
font-size:15px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
teeny tiny nit: space between font-size and 15px
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fortunately that is being removed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good.
|
Screenshots LGTM - thanks! |
advocacy.code.org
no state selected
wide page (narrow box)
narrow page (wide box)
code.org/promote
no state selected
wide page (narrow box)
narrow page (wide box)
Also some content changes to the four quarter slots on http://advocacy.code.org