Fix and re-enable webpurify tests #21878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebPurify unit tests have been frequently failing on Circle CI lately.
While I explored changes to the
WebPurify
component recently, neither the source file, nor the test file, nor the VCR files have been touched since October.VCR debug logging revealed the issue.
Ends up trying to match
fakekey
when it should be matchingmocksecret
:Meaning I actually broke the
WebPurify
tests by adding these Azure tests.The root of the problem is that these VCR replacements share a global namespace, and there's a collision in the
<API_KEY>
replacement. I think these tests would pass if the random test ordering loaded themocksecret
replacement first.The fix is to give the Azure tests a unique secret replacement, like
<AZURE_API_KEY>
, and regenerate those VCR files.