Always seed school_districts when using stubbed data #21937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Apr 19, 2018
There was a problem hiding this comment.
Seems reasonable, but I'd get @breville's approval too since I haven't been following this closely.
breville
approved these changes
Apr 19, 2018
|
cc @sureshc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to work around the issues discussed in #21823. There are fewer than 20 records in the stub school_districts data so seeding does not take much time.
It is still a good idea to get the data on test cleaned up. That is a non-trivial task that requires tracking down all the sources of extra rows, stopping those rows from getting created, and then removing all of the extra rows along with transitive references (schools, school_infos, etc.)