Upgrade Yarn to v1.6

[islemaster]

Upgrades our Yarn dependency from v0.23.2 to v1.6.0.

We last did this about a year ago. This change will require developers to update their local yarn version, probably by following the appropriate steps in SETUP.md again. I just ran the following to update:

curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.6.0

[caleybrock]

Looks good to me.

[islemaster]

Surprise! We were no longer calling this file anywhere, so we've been using yarn 0.27.5 in our Circle builds, probably since the Circle 2.0 upgrade. This probably accounts for some of the weird yarn.lock issues we've run into.

[islemaster]

PTAL

[balderdash]

Can we set this up in our docker image instead of installing it every time?

[islemaster]

Good point. Looks like we'd change that here:

code-dot-org/.circleci/Dockerfile

Lines 23 to 25 in 6f36db9

	# add yarn
	RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - && \
	echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list

But I potentially need @wjordan to push the updated image to Docker hub?

[islemaster]

Discussed in person. I'm going to go ahead and merge this with the install in the Circle config (takes about 4s) and expect follow-up work to move our docker image someplace with shared ownership, at which time we can move this up to the image.

[joshlory]

Did this ever happen?

follow-up work to move our docker image someplace with shared ownership

[islemaster]

I suspect it did - the yarn version is set in the dockerfile here:

code-dot-org/docker/dockerfiles/Dockerfile

Line 32 in 09b4a13

yarn=1.6.0-1 \

@uponthesun may know more about where our image lives / how to update it.

[aoby]

LGTM, but I'm not very familiar with the circle config