Add a location picker #21955
Merged
Add a location picker #21955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 19, 2018 17:46
Generate code to just return the one argument, don't call a function
Hamms
approved these changes
Apr 24, 2018
apps/src/StudioApp.js
Outdated
| @@ -2320,6 +2320,7 @@ StudioApp.prototype.setStartBlocks_ = function (config, loadLastAttempt) { | |||
| this.loadBlocks(startBlocks); | |||
| } catch (e) { | |||
| if (loadLastAttempt) { | |||
| console.error(e); | |||
There was a problem hiding this comment.
If the problem is an undefined block, the mainBlockSpace.clear() call on the next line throws a less useful exception, so I want to expose this one.
Cleaned it up a little to actually re-throw this exception if the following lines run into a problem.
| }) => { | ||
| if (!func === !expression) { | ||
| throw new Error('Provide either func or expression, but not both'); | ||
| if (!!func + !!expression + !!simpleValue !== 1) { |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of the changes in this PR:
simpleValueoption to blocks, which makes them act as a simple wrapper around a single argument.GamelabVisualizationColumn, depending on actions and state from theLocationPickerModule.