Progress: adjust height and align header elements #21988
Conversation
| @@ -40,6 +39,7 @@ class LessonSelector extends Component { | |||
| <option | |||
| value={lesson.position} | |||
| key={lesson.id} | |||
| style={{padding: 10}} | |||
There was a problem hiding this comment.
nit: move to style component instead of inline
Erin007
force-pushed
the
progress-dropdown-styles
branch
from
aeda1ea
to
e3ca884
Compare
Erin007
force-pushed
the
progress-dropdown-styles
branch
from
00eba56
to
7149b3d
Compare
| @@ -8,8 +8,7 @@ const styles = { | |||
| display: 'block', | |||
| boxSizing: 'border-box', | |||
| fontSize: 'medium', | |||
| padding: '0.8em', | |||
| marginBottom: 10, | |||
| height: 34 | |||
| }, | |||
| heading: { | |||
| marginBottom: 0, | |||
There was a problem hiding this comment.
Question: Why is there a comma after the marginBottom (it's the only property:value pair for heading)? There isn't a comma after (height: 34), which is inline with the style guide.
There was a problem hiding this comment.
Oh, the comma is on line 15 is probably because I had a style after marginBottom that I ended up not needing so I removed it. I have a slight preference for trailing commas because if I add something later, I will only see the change that I added in the diff not the changes that I added AND the additional comma on the line preceding the change. 🤷🏼♀️
|
Since this is still behind a flag, I'll spot check the other browsers on staging. |
Before:
After:
