Dashboard: restrict social sharing links #22016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Share your project: already had Facebook and Twitter reachability checking, but Twitter link was not working, which is now fixed. A comment in the code asserts that this UI is not reachable by students < 13 years. New congrats: now does reachability checking and < 13 years checking for the Facebook and Twitter share buttons. End of puzzle dialog: already hid Facebook and Twitter buttons for < 13 years, now does reachability checking too.
breville
requested review from
davidsbailey,
joshlory,
tanyaparker and
poorvasingal
davidsbailey
requested changes
Apr 25, 2018
There was a problem hiding this comment.
A comment in the code asserts that this UI is not reachable by students < 13 years.
It has very recently become possible to enable project sharing for students under 13, so the comment you're referring to is no longer accurate. This means we would need an under-13 check in the share dialog code as well.
|
@davidsbailey Thanks for an excellent catch. I'd also been curious about that comment and learnt similar, so this PR will be updated to fix the comment and get the additional functionality. |
Recent changes now allow students < 13 years to "share your project" if their teacher has allowed it. A separate bug is tracking that the server currently rejects this sharing. This change simply updates a related comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share your project
already had Facebook and Twitter reachability checking, but Twitter link was not working, which is now fixed. A comment in the code asserts that this UI is not reachable by students < 13 years.
New congrats
now does reachability checking and < 13 years checking for the Facebook and Twitter share buttons.
End of puzzle dialog
already hid Facebook and Twitter buttons for < 13 years, now does reachability checking too.