Fix public thumbnails #22026
Merged
Fix public thumbnails #22026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures IO stream pointer is at the beginning of the file before using it in the response. Thumbnails for App Lab and Game Lab are coming back blank, because we pass an IO object to the image moderation component (it seemed preferable to operate on streams whenever possible) and it doesn't rewind the stream pointer so the stream we return for the response is already at end-of-file. This is solved by rewinding the stream pointer before returning it because we always want to return the whole file in the response.
aoby
approved these changes
Apr 24, 2018
| file.read | ||
| # Return true so this expectation matches any arguments. | ||
| true | ||
| end |
|
In the |
|
Merging to ensure this gets shipped today, happy to make adjustments in a follow-up PR if there's any other feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke it.
When we enabled image moderation yesterday we started getting empty thumbnails in the public gallery.
Root cause: We pass an
IOinstance to theImageModerationmodule, and we later use thatIOas the response body. WhenImageModerationreads theIOobject its read cursor gets advanced to the end of the file, and subsequent reads give an empty result. The solution is to rewind the read cursor to the beginning of the file before we return theIOas the response body.My unit tests didn't catch this because they stub
ImageModeration.rate_imageand therefore in tests the read cursor wasn't advanced the way it is in production code. I've expanded one of the test cases to simulate this read behavior.