Progress: Add top margin on pill bubble to match other bubbles #22064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleybrock
force-pushed
the
fix-top-margin-pill
branch
from
0a27a98
to
a280547
Compare
|
@balderdash is there anywhere else in CSF I should test these bubble changes? I think I found all the use cases. |
|
I can't think of anything else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Pill bubbles by themselves had no top margin in a progress bubble set. When they were paired with other bubbles, they did have a top margin.
After
Match margin of the circle bubbles so the pills can stand on their own.
Added an example to storybook.
Screenshots inline.
