Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress: more consistent styling for teal links #22083

Merged
merged 1 commit into from Apr 26, 2018
Merged

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented Apr 26, 2018

The "< View All Sections" link and the "View course >" link on the teacher dashboard progress tab were stylistically inconsistent. This PR styles the "View All Sections" link to be more consistent with our React styling. They won't match perfectly because the chevron on Pegasus for "view all sections" is a unicode symbol and the chevron in the React component for "view course" is a FontAwesome icon. We'll live with these minor inconsistencies until we move the top level teacher dashboard component to React.

screen shot 2018-04-26 at 11 00 11 am

gsheet i18n sheet was updated to have sentence casing. Currently one staging:
screen shot 2018-04-26 at 11 00 30 am

Combo of these two changes will be the final result.

@Erin007 Erin007 merged commit 31c9f08 into staging Apr 26, 2018
@Erin007 Erin007 deleted the teal-links branch April 26, 2018 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants