Remove school info "optional" split test #22109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewjordan
commented
Apr 27, 2018
| @@ -221,7 +194,7 @@ window.SignupManager = function (options) { | |||
| ReactDOM.render( | |||
| <div> | |||
| <h5 style={{fontWeight: "bold"}}> | |||
| {showOptional ? i18n.schoolInformationOptionalHeader() : i18n.schoolInformationHeader()} | |||
| {i18n.schoolInformationHeader()} | |||
There was a problem hiding this comment.
TODO: remove i18n.schoolInformationOptionalHeader from strings, should not be needed anymore
islemaster
force-pushed
the
remove-optional-ab-test
branch
from
0510530
to
fe68a72
Compare
|
Rebased, removed the i18n string Eric mentioned, and tested locally. Everything looks good! Will merge after this passes Circle again. |
islemaster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing to pass along to Brad for testing and finishing