Don't show purple bubbles on "perfected" assessments #22124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mehalshah will this change have any implications for Peer Review levels? |
|
This doesn't affect Peer Review. PR uses |
|
@mehalshah what status do they use when first submitted? Thanks! |
Hamms
approved these changes
May 1, 2018
|
@joshlory - |
This was referenced May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request from @ryansloan and @poorvasingal. "Assessment" means different things in different contexts. In CSD/CSP it's usually a specific level we want teachers to manually check. In CSF it's a multiple choice level or puzzle with one correct answer.
If the assessment is marked
perfectthen show it as green. Otherwise show it as the normal assessment color (purple).