restore escaped carriage returns coming out of crowdin #22125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
changed the title
Hamms
force-pushed
the
sanitize-newlines-out-of-crowdin
branch
from
4263b50
to
73a5f01
Compare
Follow-up to #22125 Also as a side effect switches a lot of strings over from YAML literal-style strings (with `|`) to just regular strings
joshlory
approved these changes
May 2, 2018
…crowdin-content Sync out i18n data with santizied carriage returns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #21964
Before
After
These stray "\r"s were manifesting in instructions, script descriptions, and authored hints. They were present in markdown instructions and only not manifesting there because we aren't displaying translated markdown instructions (yet!).
They are also present in unplugged level content, but were not manifesting there; could very well be that we are manually fixing them only for unplugged levels. I'm going to spend a bit of time as a follow-up seeing if there's something I can remove