Cache requests on teacher dashboard #22147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Context: |
Hooray!
islemaster
added a commit
that referenced
this pull request
May 2, 2018
Yesterday @balderdash discovered and deployed [this awesome fix](#22147) that makes angular cache the results of API calls in teacher dashboard, significantly reducing redundant calls. We deployed this setting with a DCDO flag so we could quickly enable/disable it in case it caused unexpected problems. After deploying it today, it's had a clear positive impact and we haven't had reports of serious issues with the caching behavior yet. This change removes the DCDO flag (because simpler configuration is better) and leaves the caching change in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn angular service caching on for the sections service, see: https://docs.angularjs.org/api/ng/service/$http#caching