Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import screens after asset import completes #22160

Merged
merged 2 commits into from
May 3, 2018
Merged

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented May 2, 2018

  • Importing screens that contain image assets can fail because the screens were imported before the asset imports were complete. Worse, the browser would then cache the 404 response for 1-2 hours and the student had to do a manual refresh to see the image in their project
    • NOTE: the 404 doesn't repro easily in a development environment
  • Fixed the sequencing in the import

Network comparison (the first request is the copy-assets API call, the JPG request is the image being loaded once added into the screen in design mode)

Before:
screen shot 2018-05-02 at 11 02 14 am
After:
screen shot 2018-05-02 at 11 16 35 am

@cpirich cpirich requested a review from islemaster May 2, 2018 18:21
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thanks for the fix.

@cpirich cpirich merged commit 6d44453 into staging May 3, 2018
@cpirich cpirich deleted the applab_import_fix branch May 3, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants