New Game Lab D-Pad and Space Button (for mobile devices) #22170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@poorvasingal to check out the screenshot! |
|
This is awesome! Should we first ship this behind a flag so we can test first? |
islemaster
reviewed
May 4, 2018
| @@ -1605,6 +1684,7 @@ a.WireframeButtons_active, div.WireframeButtons_active { | |||
|
|
|||
| .legacy-share-view { | |||
| overflow: hidden; | |||
| position: fixed; | |||
There was a problem hiding this comment.
I reverted this change because of a regression in the share view layout. This position: fixed style seems to be the problem - when I disable it, the layout snaps back into position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
showDPad, which is typically true)onMouseUpto make it multi-touch friendly - at least on devices that sendtouchendevents. If we see theevent.touches, we ensure that there are no other active touches before proceeding to reset the D-Pad and soft buttons.