Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artist yarn import #22173

Merged
merged 2 commits into from
May 3, 2018
Merged

Artist yarn import #22173

merged 2 commits into from
May 3, 2018

Conversation

joshlory
Copy link
Contributor

@joshlory joshlory commented May 3, 2018

Follows the pattern in PR #17564.

@joshlory joshlory requested a review from Hamms May 3, 2018 00:03
@joshlory
Copy link
Contributor Author

joshlory commented May 3, 2018

Finish up Artist npm module extraction, so we’re building from https://github.com/code-dot-org/artist

Hamms
Hamms approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshlory joshlory merged commit 6dcef10 into staging May 3, 2018
@joshlory joshlory deleted the artist-yarn branch May 3, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshlory @Hamms