Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only csf facilitators and workshop admins can select "none" for regio… #22179

Merged
merged 5 commits into from
May 8, 2018
Merged

only csf facilitators and workshop admins can select "none" for regio… #22179

merged 5 commits into from
May 8, 2018

Conversation

clareconstantine
Copy link

@clareconstantine clareconstantine commented May 3, 2018 •
edited

…nal partner; if only one option, not a dropdown

version without a dropdown:
screen shot 2018-05-03 at 5 35 03 pm

aoby
aoby approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@aoby aoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to update the new workshop eyes tests (which are now failing).

Also please include a screenshot of the no-choice version if it's not too hard to set up.

@clareconstantine clareconstantine merged commit d43ff9b into staging May 8, 2018
@clareconstantine clareconstantine deleted the new-workshop-partner branch June 6, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoby aoby aoby approved these changes

@mehalshah mehalshah Awaiting requested review from mehalshah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clareconstantine @aoby