Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add S3 upload field to video edit form #22187

Merged
merged 7 commits into from May 10, 2018
Merged

Add S3 upload field to video edit form #22187

merged 7 commits into from May 10, 2018

Conversation

joshlory
Copy link
Contributor

@joshlory joshlory commented May 3, 2018

image

@joshlory joshlory requested a review from davidsbailey May 3, 2018 22:28
@joshlory
Copy link
Contributor Author

joshlory commented May 3, 2018

Level builder video auto-upload to S3

@davidsbailey
Copy link
Member

How would I see the S3 download link header in the levelbuilder UI today?

@joshlory joshlory mentioned this pull request May 4, 2018
Merged
@joshlory
Copy link
Contributor Author

joshlory commented May 4, 2018

@davidsbailey visit http://localhost-studio.code.org:3000/videos then click an "Edit" link or "New Video".

davidsbailey
davidsbailey approved these changes May 4, 2018
View reviewed changes
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@joshlory joshlory merged commit 177d102 into staging May 10, 2018
@joshlory joshlory deleted the video-edit-s3-metadata branch May 10, 2018 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

Assignees
No one assigned
Labels
content-pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshlory @davidsbailey