Sanitize comment block for under 13 shares #22204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
force-pushed
the
redact-comment-block-text-for-under-13-shares
branch
from
5bcd210
to
c2ced6f
Compare
Hamms
changed the title
Hamms
changed the title
Hamms
requested review from
davidsbailey and
islemaster
and removed request for
davidsbailey
islemaster
approved these changes
May 4, 2018
|
Before merging; I figure the change itself will be small enough relative to the rest of this that it was worth getting a review beforehand |
|
Improved and fixed tests; improved by adding tests for admin case, fixed by using a better stubbing method. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing a project created by an under-13 user, only the user themselves should be able to view comment blocks; all other users should see a sanitized version of the source.
TODO: need to figure out which version admins should see, and add a test for that case