Flush Honeybadger events after notify #22205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoby
approved these changes
May 4, 2018
There was a problem hiding this comment.
LGTM, but I'm surprised we have to call this. The docs seem to imply it's only needed in tests to force synchronicity. We should report this to Honeybadger support. I'd expect them to auto-flush before the process exits. These cronjobs exit immediately vs. our pegasus and dashboard servers, so those are less likely to need the flush but I'm still concerned now that we might miss notifications in some situations on our front ends (e.g. before a crash or teardown).
|
Agreed, this seems odd. I'll mention it in the ticket I opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we were sometimes dropping reported Honeybadger alerts related to failed cron tasks (our contact rollups task has been failing for a week with an exception, but wasn't showing up in HB); @wjordan suggested that flushing might help, and it appears that it does. This specifically touches the
notify_command_errorcall; I did not do a deep dive into other usages to see if we might be dropping anything else, but this at least should fix the situation for all of our crons.