Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats tab cleanup #22218

Merged
merged 7 commits into from
May 7, 2018
Merged

Stats tab cleanup #22218

merged 7 commits into from
May 7, 2018

Conversation

maddiedierker
Copy link
Contributor

This week, we deployed some fixes to teacher dashboard that included rewriting the "stats" tab in React. We were in a bit of a rush to get the changes out, so this PR addresses some things we wanted to clean up.

What's in this PR

  • Implement feedback from PR Stats tab in React #22161
  • Add necessary text to i18n
  • Style tweaks (image comparison below)
  • Remove ability to sort students by completed levels or lines of code
  • Unit tests for StatsTable

Before

screen shot 2018-05-04 at 5 02 11 pm

After

screen shot 2018-05-04 at 5 01 36 pm

@maddiedierker maddiedierker merged commit 2e1c275 into staging May 7, 2018
@maddiedierker maddiedierker deleted the stats-tab-cleanup branch May 7, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants