Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve hint prompt threshold by moving it to Level model #22241

Merged
merged 1 commit into from Jun 7, 2018
Merged

Preserve hint prompt threshold by moving it to Level model #22241

merged 1 commit into from Jun 7, 2018

Conversation

joshlory
Copy link
Contributor

@joshlory joshlory commented May 8, 2018

Better fix for PR #22102.

@joshlory joshlory requested a review from Hamms May 8, 2018 00:02
@joshlory joshlory mentioned this pull request May 8, 2018
Closed
Hamms
Hamms reviewed May 8, 2018
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we still need a plan to do this in such a way that the data ends up in the .level files, which means we probably want to run this on levelbuilder, which means we probably need to use something other than ids to identify the levels

@joshlory
Copy link
Contributor Author

Re-calculate hint prompt data to enable them on Course A-F levels

@joshlory
Copy link
Contributor Author

joshlory commented Jun 7, 2018

Planning to update import_hint_prompt_threshold.rb to key by level name instead of ID in a followup PR.

@joshlory joshlory merged commit 935f8ad into staging Jun 7, 2018
@joshlory joshlory deleted the move-hint-prompt-threshold-to-level branch June 7, 2018 20:53
@joshlory joshlory mentioned this pull request Jun 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshlory @Hamms